#56 ✓resolved
Masayoshi Takahashi

[PATCH] tests failed when Encoding.default_external is not ASCII-8BIT

Reported by Masayoshi Takahashi | June 24th, 2009 @ 06:28 PM | in 1.0

In ruby 1.9.1 on my OS X, many tests failed.

http://gist.github.com/135436

Because Encoding.default_external is UTF-8 in my environment.

$ ruby -e 'p Encoding.default_external' #=> #<Encoding:UTF-8>

So StringIO#external_encoding become UTF-8, not ASCII-8BIT.

I made a patch for tests of Rack using force_encoding if the method is defined. It should be OK for both 1.8 and 1.9.

http://github.com/takahashim/rack/commit/93268948ddc2f791d93d413f59...

Thanks in advance,

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

People watching this ticket

Pages