Comments and changes to this ticket
-
-
josh January 21st, 2009 @ 12:09 AM
We may still want to support allowing "empty" files. So a user could upload "foo.txt" with no contents.
I think we really want to check for a filename. Let me whip up some more tests and fixtures.
Ryan, should this be committed to the 0.9 branch, or just master?
Related Rails Ticket: http://rails.lighthouseapp.com/p...
-
-
Ryan Tomayko January 21st, 2009 @ 03:05 AM
Josh: my understanding is that everything should go to master and then Christion will cherry-pick specific commits into the 0.9 branch if a maint release is required. Let me send an email right now to get this cleared up.
-
josh January 21st, 2009 @ 06:24 PM
- Milestone changed from “0.9” to “1.0”
- State changed from “new” to “resolved”
-
Gleb Pomykalov May 21st, 2009 @ 08:32 AM
Why did you select the nil value? I think that the correct value is "". In rails, if you post some params, the model should do something with the values. So when we post no file, the correct behaviour should be "to destroy file", but if we don't send param with file (e.g. "uploaded_data") we show not touch it. It is so in old versions of rails (2.1)
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Gleb Pomykalov
josh