Response caches the body in Session::Pool
Reported by foobar | December 22nd, 2009 @ 12:32 PM
I have encountered a problem with the Rack::Session::Pool middleware. It creates a Rack::Response object which iterates over the body. Large files send by Static (underlying middleware) will be read to memory. There should be a possibility to disable the buffering. Buffering makes only sense if the middleware modifies the body.
Possibilities to fix this:
- Use Rack::Response object only if buffering is needed. Don't use
it in core middlewares like Session::Pool. - Add an option to
disable buffering and use the option in the core middlewares. -
Split response class into two classes. One simple only for header
manipulation and one extended with buffering.
Comments and changes to this ticket
-
foobar December 22nd, 2009 @ 12:59 PM
Ah sry, this one is fixed in the github repository. But you should really shorten your release cycles.
-
josh January 10th, 2010 @ 03:00 PM
- State changed from new to resolved
-
josh January 10th, 2010 @ 03:00 PM
- no changes were found...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป